[azopenai] Token counts aren't contractual for our client, no need to test for it. #25728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardpark-msft
requested review from
PratibhaShrivastav18,
achauhan-scc,
chlowell,
glecaros,
jhendrixMSFT and
kingernupur
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes brittle assertions that checked for exact token counts in chat completion tests. The test now validates that token usage values are populated (greater than zero) rather than matching specific values, making the tests more resilient to model changes.
Key Changes:
- Replaced exact token count assertions with checks that verify token counts are positive values
- Removed model-specific hard-coded values that could cause test failures when models change
| // let's just make sure that the #'s are filled out. | ||
| require.Greater(t, resp.Usage.CompletionTokens, int64(0)) | ||
| require.Greater(t, resp.Usage.PromptTokens, int64(0)) | ||
| require.Greater(t, resp.Usage.TotalTokens, int64(0)) |
There was a problem hiding this comment.
[nitpick] Consider using require.NotZero instead of require.Greater(t, ..., int64(0)) for consistency with similar checks in client_completions_test.go (lines 33-35). Both approaches are functionally equivalent, but NotZero is more concise and aligns with the existing pattern in the codebase.
Suggested change
| require.Greater(t, resp.Usage.TotalTokens, int64(0)) | |
| require.NotZero(t, resp.Usage.TotalTokens) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for breakage mentioned here: #25727